add withLog parameter to debug_traceCall #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chexware
added
A3-inprogress
added 4 commits
August 2, 2024 22:09
Coverage Report@@ Coverage Diff @@
## master aleks-debug-trace-call-options +/- ##
==================================================================
+ Coverage 80.90% 80.92% +0.02%
Files 286 286
+ Lines 81838 81932 +94
==================================================================
+ Hits 66206 66303 +97
- Misses 15632 15629 -3
|
added 9 commits
August 7, 2024 17:00
…d with_log parameter from TraceType::Raw
…routed it to call_list listener
RomarQ
reviewed
Aug 13, 2024
RomarQ
reviewed
Aug 13, 2024
RomarQ
reviewed
Aug 13, 2024
chexware
removed
the
A3-inprogress
librelois
reviewed
Aug 13, 2024
RomarQ
reviewed
Aug 13, 2024
noandrea
added
the
D3-trivial
Co-authored-by: Aleksandar Brayanov <aleksandar@moonsonglab.com>
WASM runtime size check:Compared to target branchMoonbase runtime: 2184 KB (no changes) ✅ Moonbeam runtime: 2120 KB (no changes) ✅ Moonriver runtime: 2132 KB (no changes) ✅ Compared to latest release (runtime-3102)Moonbase runtime: 2184 KB (+244 KB compared to latest release) Moonbeam runtime: 2120 KB (+220 KB compared to latest release) Moonriver runtime: 2132 KB (+232 KB compared to latest release) |
gonzamontiel
reviewed
Sep 6, 2024
gonzamontiel
previously approved these changes
Sep 6, 2024
librelois
previously approved these changes
Sep 6, 2024
RomarQ
added
not-breaking
librelois
approved these changes
Sep 6, 2024
gonzamontiel
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adding additional parameter to
debug_traceCallthat enables returns of logs calls similar to Geth's tracerWhat important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?